Parameterize target_soc in charge/discharge services for Huawei#3407
Merged
springfall2008 merged 1 commit intomainfrom Feb 21, 2026
Merged
Parameterize target_soc in charge/discharge services for Huawei#3407springfall2008 merged 1 commit intomainfrom
springfall2008 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR parameterizes the target_soc field in Huawei Solar charge and discharge service calls, replacing hardcoded values with dynamic templates that use Predbat's calculated optimal battery state of charge targets.
Changes:
- Replaces hardcoded
target_soc: 100withtarget_soc: "{target_soc}"incharge_start_service - Replaces hardcoded
target_soc: 10withtarget_soc: "{target_soc}"indischarge_start_service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.