Conversation
sparsick
force-pushed
the
windows-support
branch
2 times, most recently
from
4083dfc to
40e189f
Compare
sparsick
force-pushed
the
windows-support
branch
from
40e189f to
6efab9e
Compare
sparsick
force-pushed
the
windows-support
branch
from
b5d84a5 to
513c1d8
Compare
sparsick
force-pushed
the
windows-support
branch
from
11524dd to
3e14f9b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
Coverage 88.81% 88.81%
Complexity 49 49
=========================================
Files 7 7
Lines 161 161
Branches 7 7
=========================================
Hits 143 143
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
aalmiray
reviewed
May 23, 2024
| maven-version: 3.9.6 | ||
| - name: 'Build' | ||
| run: | | ||
| mvn --fail-at-end --batch-mode --no-transfer-progress clean verify No newline at end of file |
Contributor
There was a problem hiding this comment.
No need to invoke clean after a fresh checkout
| with: | ||
| distribution: 'temurin' | ||
| java-version: '17' | ||
| - uses: stCarolas/setup-maven@v5 |
Contributor
There was a problem hiding this comment.
Prefer the use of the Maven wrapper and set it up in the project instead
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/cache@v4 |
Contributor
There was a problem hiding this comment.
use cache: maven setting in actions/setup-java instead
| linux-build: | ||
| name: "JDK 21 Eclipse Temurin Linux" | ||
| runs-on: ubuntu-latest | ||
| container: "maven:3.9.6-eclipse-temurin-21" |
Contributor
There was a problem hiding this comment.
Why would a custom container be needed? Isn't the default option enough?
Also, removing this container and using a run matrix will remove duplication for linux and windows runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.