Remove product filters require #6408
Open
+76
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
==========================================
- Coverage 89.50% 89.49% -0.01%
==========================================
Files 981 981
Lines 20479 20476 -3
==========================================
- Hits 18329 18326 -3
Misses 2150 2150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is already required in solidus_starter_frontend. Removing the explicit require from core simplifies overriding it in client applications. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Sofia Besenski <sofia@super.gd>
This change cleans up some of the formatting and language around how product filters should be constructed. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Sofia Besenski <sofia@super.gd>
forkata
force-pushed
the
remove-product-filters-require
branch
from
e971bae to
7461408
Compare
This cleans up some of the sample product filters provided to be a bit more performant and easier to read. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Sofia Besenski <sofia@super.gd>
forkata
force-pushed
the
remove-product-filters-require
branch
from
7461408 to
d7cb914
Compare
Contributor
Author
|
I don't believe the code coverage changed here, I think the check here is just indicating that the product filters specs did not cover all the code paths. We can look at adding some code coverage if that's needed to merge this change. |
kennyadsl
approved these changes
Jan 16, 2026
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
👍 I don't think it's needed to add more coverage for the purpose of this PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the explicit require for product filters to simplify overriding it in client applications. We have confirmed that only the test files that require the filters depend on them. The product filters are also explicitly required in the solidus_starter_frontend which depends on them.
Fixes #6406
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: