Skip to content

chore(language-server): integrate LS#6563

Open
Team-Hammerhead wants to merge 1 commit intomainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#6563
Team-Hammerhead wants to merge 1 commit intomainfrom
chore/automatic-upgrade-of-ls

Conversation

@Team-Hammerhead
Copy link
Contributor

@Team-Hammerhead Team-Hammerhead commented Feb 19, 2026

Changes since last integration of Language Server

commit 8e397d308d19c24dfc8427afea61280a86475081
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Thu Feb 19 17:49:34 2026 +0000

    fix: allow setting a blank org [IDE-1566] (#1115)
    
    
    Previously you had to restart the IDE to go back to actually using the blank org (the user's preferred org from the web UI).
    
    Also changed `Settings.Organization` to a pointer, so we can differentiate between unset and blank (makes writing tests easier, so you don't have to keep specifying the org in the `Settings` struct).
    
    Removed slug checking from `isOrgDefault`, it wasn't being used as we were always checking against an org UUID (GAF was resolving the slugs to orgs for us), so I removed it to simplify the code.

M	application/config/client_settings.go
M	application/config/config.go
M	application/config/config_test.go
M	application/server/configuration.go
M	application/server/configuration_test.go
M	application/server/server_smoke_test.go
M	application/server/server_test.go
M	domain/ide/command/configuration_command.go
M	domain/ide/command/folder_handler.go
M	domain/ide/command/folder_handler_test.go
M	infrastructure/code/snyk_code_http_client_test.go
M	infrastructure/configuration/config_html_test.go
M	infrastructure/oss/oss_test.go
M	internal/testutil/test_setup.go
M	internal/types/config_resolver.go
M	internal/types/config_resolver_test.go
M	internal/types/lsp.go
M	scripts/config-dialog/main.go

@Team-Hammerhead Team-Hammerhead requested review from a team as code owners February 19, 2026 18:12
@github-actions
Copy link
Contributor

Warnings
⚠️

"chore: automatic integration of language server 8e397d308d19c24dfc8427afea61280a86475081" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against a9812d1

@snyk-pr-review-bot
Copy link

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Breaking Change 🟠 [major]

The update to github.com/snyk/snyk-ls (commit 8e397d30) introduces a breaking API change: the Settings.Organization field was converted from a string to a *string (pointer). Since cliv2 depends on snyk-ls, any code within this repository that directly references or assigns to this field will now fail to compile due to the type mismatch. Furthermore, if the field is accessed without proper nil checks in the consumer code, it could lead to runtime panics (nil pointer dereference). The PR does not include any corresponding code changes to address this transition.

github.com/snyk/snyk-ls v0.0.0-20260219174934-8e397d308d19
Possible Regression 🟠 [major]

The integrated version of the Language Server removed slug checking from the isOrgDefault function, based on the assumption that the Go Application Framework (GAF) always resolves slugs to UUIDs. If the CLI integration in cliv2 relies on the Language Server to handle organization slugs directly, or if there are code paths where slugs are not pre-resolved, this removal could lead to incorrect organization identification or broken "default organization" logic. The impact is a potential misconfiguration where the user's preferred organization is not correctly recognized.

github.com/snyk/snyk-ls v0.0.0-20260219174934-8e397d308d19
📚 Repository Context Analyzed

This review considered 1 relevant code sections from 1 files (average relevance: 0.75)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments