You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
commit 8e397d308d19c24dfc8427afea61280a86475081
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date: Thu Feb 19 17:49:34 2026 +0000
fix: allow setting a blank org [IDE-1566] (#1115)
Previously you had to restart the IDE to go back to actually using the blank org (the user's preferred org from the web UI).
Also changed `Settings.Organization` to a pointer, so we can differentiate between unset and blank (makes writing tests easier, so you don't have to keep specifying the org in the `Settings` struct).
Removed slug checking from `isOrgDefault`, it wasn't being used as we were always checking against an org UUID (GAF was resolving the slugs to orgs for us), so I removed it to simplify the code.
M application/config/client_settings.go
M application/config/config.go
M application/config/config_test.go
M application/server/configuration.go
M application/server/configuration_test.go
M application/server/server_smoke_test.go
M application/server/server_test.go
M domain/ide/command/configuration_command.go
M domain/ide/command/folder_handler.go
M domain/ide/command/folder_handler_test.go
M infrastructure/code/snyk_code_http_client_test.go
M infrastructure/configuration/config_html_test.go
M infrastructure/oss/oss_test.go
M internal/testutil/test_setup.go
M internal/types/config_resolver.go
M internal/types/config_resolver_test.go
M internal/types/lsp.go
M scripts/config-dialog/main.go
The update to github.com/snyk/snyk-ls (commit 8e397d30) introduces a breaking API change: the Settings.Organization field was converted from a string to a *string (pointer). Since cliv2 depends on snyk-ls, any code within this repository that directly references or assigns to this field will now fail to compile due to the type mismatch. Furthermore, if the field is accessed without proper nil checks in the consumer code, it could lead to runtime panics (nil pointer dereference). The PR does not include any corresponding code changes to address this transition.
The integrated version of the Language Server removed slug checking from the isOrgDefault function, based on the assumption that the Go Application Framework (GAF) always resolves slugs to UUIDs. If the CLI integration in cliv2 relies on the Language Server to handle organization slugs directly, or if there are code paths where slugs are not pre-resolved, this removal could lead to incorrect organization identification or broken "default organization" logic. The impact is a potential misconfiguration where the user's preferred organization is not correctly recognized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes since last integration of Language Server