feat: add os dragonfly rollout release flag in ff interceptor

[paulrosca-snyk]

Pull Request Submission Checklist

• Follows CONTRIBUTING guidelines
• Commit messages
  are release-note ready, emphasizing
  what was changed, not how.
• Includes detailed description of changes
• Contains risk assessment (Low | Medium | High)
• Highlights breaking API changes (if applicable)
• Links to automated tests covering new functionality
• Includes manual testing instructions (if necessary)
• Updates relevant GitBook documentation (PR link: ___)
• Includes product update to be announced in the next stable release notes

What does this PR do?

Adds the rollout-dfly-os-cli release flag to the cliv2 feature flag interceptor.

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

N/A

[j-luong]

nitpick: maybe we can apply the rule of three here and refactor this?

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential Interception Bypass 🟡 [minor] The regex in NewLegacyFeatureFlagInterceptor allows for an optional trailing slash (/?) at the end of the feature flag path. However, the featureFlagPaths map contains keys that do not include a trailing slash. If a client makes a request with a trailing slash (e.g., /v1/cli-config/feature-flags/rollout-dfly-os-cli/), the interceptor's condition will match, but the lookup in GetHandler will fail because req.URL.Path will include the slash, causing the interceptor to return the original request without applying the intended configuration override. While this behavior is consistent with the previous switch implementation, it represents a discrepancy between the matching logic and the handling logic that could be addressed by normalizing the path (e.g., using strings.TrimSuffix(req.URL.Path, "/")) before the map lookup. configKey, ok := featureFlagPaths[req.URL.Path] if !ok { return req, nil }

📚 Repository Context Analyzed This review considered 4 relevant code sections from 4 files (average relevance: 0.97) cliv2/internal/proxy/interceptor/legacyfeatureflaginterceptor.go (lines 1-81) cliv2/internal/proxy/interceptor/v1_analytics.go (lines 1-170) cliv2/internal/proxy/interceptor/networkinjector.go (lines 1-44) CONTRIBUTING.md (lines 301-400)