feat(reachability): skip uploading invalid files#6530
Draft
paulrosca-snyk wants to merge 1 commit intomainfrom
Draft
feat(reachability): skip uploading invalid files#6530paulrosca-snyk wants to merge 1 commit intomainfrom
paulrosca-snyk wants to merge 1 commit intomainfrom
Conversation
5985505 to
6a66589
Compare
6a66589 to
d8a0553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Changes the behaviour of
snyk test --reachabilityandsnyk sbom test --reachabilityso that the commands no longer fail when uploading the source code if there are invalid files inside the directory.Where should the reviewer start?
How should this be manually tested?
Running
snyk test --reachability/snyk sbom test --reachabilityinside a directory with invalid files (e.g broken symlinks) should result in a test running and results being displayed.What's the product update that needs to be communicated to CLI users?
snyk test --reachability/snyk sbom test --reachabilitywill no longer fail when uploading the source code if there are invalid files inside the directory, instead the invalid files will be skipped and debug logs will indicate the reason (if-dis provided).Risk assessment (Low | Medium | High)?
Low - this only affects customers which have access to
--reachabilityand the files which we skipped uploading will now show in debug logs.