Conversation
2a0906e to
404f010
Compare
72336bc to
f4ce8b5
Compare
34d455c to
8e9142d
Compare
79869bb to
8e07531
Compare
401faf6 to
f9e10ca
Compare
8e07531 to
df0d731
Compare
c8828c2 to
eb32f78
Compare
a466bec to
7d1781a
Compare
eb32f78 to
042d830
Compare
7d1781a to
09a1979
Compare
This comment has been minimized.
This comment has been minimized.
1ec4efa to
765709e
Compare
This comment has been minimized.
This comment has been minimized.
765709e to
81aa36a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
32333c2 to
d26bc72
Compare
| const result = await execGoCommand(args, { cwd: root }); | ||
|
|
||
| if (result.exitCode !== 0) { | ||
| throw new CLI.GeneralCLIFailureError(extractErrorDetail(result)); |
There was a problem hiding this comment.
Suggestion: This will hide the root error and report it as general failure. It would be better to return the correct error-catalog error. You might need something like this though.
There was a problem hiding this comment.
yes this is something we've been thinking about, but out of scope for this particular ticket. We actually have a ticket here to start a discussion with you about how we get the errors back from the go binary properly.
There was a problem hiding this comment.
3f972b3 to
cb801e4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/lib/plugins/uv/index.ts
Outdated
| let depGraphData: DepGraphData; | ||
| try { | ||
| depGraphData = JSON.parse(result.stdout); | ||
| } catch { |
There was a problem hiding this comment.
Is it worth also adding a debug log for the exact error here, and maybe include stdout too? Then we can see what exactly was returned from the Go binary and why we couldn't parse the JSON
cb801e4 to
d03dc2d
Compare
This comment has been minimized.
This comment has been minimized.
d03dc2d to
90c9981
Compare
This comment has been minimized.
This comment has been minimized.
d26bc72 to
1109d0c
Compare
90c9981 to
8a6f292
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PR Reviewer Guide 🔍
|
| } catch (error) { | ||
| const parseError = error instanceof Error ? error.message : String(error); | ||
| debug( | ||
| 'Failed to parse dependency information JSON: %s (stdout preview: %s, stderr preview: %s)', |
There was a problem hiding this comment.
Stdout/stderr might be multiline, maybe want to add some newlines e.g.
| 'Failed to parse dependency information JSON: %s (stdout preview: %s, stderr preview: %s)', | |
| 'Failed to parse dependency information JSON: %s\nstdout preview:\n%s\nstderr preview:\n%s', |
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
For uv monitor Instead of returning a fixed depgraph we now use the go binary calling the depgraph endpoint to generate correct depgraphs for uv projects.
Where should the reviewer start?
How should this be manually tested?
run snyk monitor on a uv project