Split replace/delete original from response type#9
Closed
SiebeVE wants to merge 1 commit intoslack-php:mainfrom
Closed
Split replace/delete original from response type#9SiebeVE wants to merge 1 commit intoslack-php:mainfrom
SiebeVE wants to merge 1 commit intoslack-php:mainfrom
Conversation
|
The code looks good, but I don't understand the reason for it. Can you explain why it's necessary to split them? What have I overlooked? |
Author
|
It isn't possible if you want to add the directive slack-php-block-kit/src/Surfaces/Message.php Lines 22 to 23 in c577977 This PR changes the behaviour and allows you to send |
Author
|
See #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to delete/replace original and change the response type.
This change isn't backwards compatible and should be considered a major change.