Add rich text block, elements and parts#66
Merged
maartenpaauw merged 3 commits intoslack-php:mainfrom Dec 28, 2024
Merged
Conversation
maartenpaauw
force-pushed
the
feat/rich-text
branch
9 times, most recently
from
bb4244f to
13bd0d8
Compare
maartenpaauw
force-pushed
the
feat/rich-text
branch
2 times, most recently
from
42c0662 to
12213bd
Compare
maartenpaauw
force-pushed
the
feat/rich-text
branch
from
12213bd to
f1b042f
Compare
maartenpaauw
force-pushed
the
feat/rich-text
branch
from
63dbfba to
af67ed4
Compare
jlindblom-godaddy
left a comment
jlindblom-godaddy
left a comment
There was a problem hiding this comment.
Really nice job. That was a lot of work. I hope the library's conventions were fairly straightforward to pickup.
Collaborator
Author
|
Thank you for the kind words! The library’s architecture is straightforward and it made it easier to decide which classes should be created and where to put them. Thanks for all the effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.