Show traceback of exception in output area#166
Merged
Conversation
hannesbraun
force-pushed
the
show-exceptions
branch
from
b940885 to
877f05e
Compare
Also terminate the visualization on the first exception in user code.
hannesbraun
force-pushed
the
show-exceptions
branch
from
877f05e to
9b5248f
Compare
skogsbaer
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also terminates the trace generation for the visualization on the first exception in user code.
Side note: the exact example with libPyshell from #144 does not run. But the problem there is not the visualization but rather that the
failOnErrorparameter does not exist forrm. The general idea should work though (exceptions raised and caught within libraries should not terminate the execution).Resolves #144