Open
Conversation
8a97f64 to
3c25346
Compare
|
why 32bit |
|
Hmm.. is this a pure mingw git? is there an existing pre-built binary/package of pure mingw git? I'm not familiar with such package. As far as I know the official git-for-windows doesn't have a pure mingw build. Even the minigit busybox build still has msys2 binaries/dll for some https stuff IIRC. Regardless, even if git is useful in the context of w64dk (and it definitely is), I don't know if it belongs in w64dk. I'd think it would be more appropriate to distribute it individually, independently of w64dk. Kinda like git-for-windows, but a pure mingw package if possible. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope my opening of many PRs lately don't come off as burdensome, please do tell me if my contributions are excessive. I'm opening this one because I noticed the second paragraph in Notes mentioning an interest in Git, and I've succeeded in coming up with a somewhat simple solution (Git only depends on zlib and curl).
This adds a relatively fully functional Git to w64devkit. I've taken quite a few decisions during the production of this patch, and I'm willing to update any of them as preferred.
Decisions
http[s]://origins, which I assumed was an important feature.less.exeas the pager andvi.batas the editor. If none are specified at build time, Git would look for "less", find no match (less is "less.exe"), and fallback on simply printing everything, and for the editor, look for "vi", find no match for similar reasons and fail.makeandmake installare done in one command, because both require having the same arguments, so doing both separately would duplicate all the arguments.zipdoesn't seem to support symlinks very well, even with--symlinks, so I used thealias.cprogram to emulate those symlinks.