Add versification warnings for invalid chapter or verse numbers in USFM#381
Open
pmachapman wants to merge 1 commit intomasterfrom
Open
Add versification warnings for invalid chapter or verse numbers in USFM#381pmachapman wants to merge 1 commit intomasterfrom
pmachapman wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 72.73% 72.79% +0.06%
==========================================
Files 423 423
Lines 36029 36089 +60
Branches 4969 4974 +5
==========================================
+ Hits 26205 26271 +66
+ Misses 8733 8727 -6
Partials 1091 1091 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
39cf6ef to
5ca0162
Compare
ddaspit
reviewed
Feb 6, 2026
Contributor
ddaspit
left a comment
There was a problem hiding this comment.
The warning messages are a bit awkward. How difficult would it be to generate messages that are more appropriate for the new warnings?
@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #372
Example USFM:
Example warnings:
This change is