Fix stack empty error for an embed outside an update block#376
Merged
pmachapman merged 1 commit intomasterfrom Jan 25, 2026
Merged
Fix stack empty error for an embed outside an update block#376pmachapman merged 1 commit intomasterfrom
pmachapman merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 72.70% 72.72% +0.02%
==========================================
Files 423 423
Lines 36016 36021 +5
Branches 4966 4968 +2
==========================================
+ Hits 26186 26197 +11
+ Misses 8737 8733 -4
+ Partials 1093 1091 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
approved these changes
Jan 22, 2026
Collaborator
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit).
ddaspit
approved these changes
Jan 22, 2026
Contributor
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
243e61f to
61cfd2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sillsdev/serval#837
This change is