Add Python 3.13 support, remove Python 3.9 support#259
Conversation
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @pmachapman).
pyproject.toml line 87 at r1 (raw file):
jupyter = "^1.0.0" pandas = "^2.0.3" pyright = { extras = ["nodejs"], version = "^1.1.400" }
Why did we need the nodejs extra previously? 🤔
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 352 352
Lines 22337 22337
=======================================
Hits 20270 20270
Misses 2067 2067 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93).
pyproject.toml line 87 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Why did we need the
nodejsextra previously? 🤔
Turns out I used the wrong poetry command to update pyright. I was meant to include [nodejs] at the end, as pyright requires nodejs.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93).
pmachapman
left a comment
There was a problem hiding this comment.
@ddaspit Can you please update the rules to no longer require Python 3.9, and to instead require Python 3.13 to pass?
@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
ddaspit
left a comment
There was a problem hiding this comment.
Done
@ddaspit made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
Fixes #243
This change is