Skip to content

Add minimal logging of UnitOfWork activity#360

Merged
jasonleenaylor merged 2 commits intomasterfrom
develop
Feb 6, 2026
Merged

Add minimal logging of UnitOfWork activity#360
jasonleenaylor merged 2 commits intomasterfrom
develop

Conversation

@papeh
Copy link
Contributor

@papeh papeh commented Jan 29, 2026

  • Add logger to IOC container when LCM_TransactionLogPath environment variable is defined.
  • Use logging to add breadcrumbs to trace UOW calls.
  • This is a first step to try and track down some intermittent failures in FieldWorks unit tests.

This change is Reviewable

* Add logger to IOC container when LCM_TransactionLogPath
  environment variable is defined.
* Use logging to add breadcrumbs to trace UOW calls.
* This is a first step to try and track down some intermittent
  failures in FieldWorks unit tests.
Copy link
Contributor Author

@papeh papeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was added three years ago for debugging; is it still needed?

@papeh papeh requested a review from jasonleenaylor January 29, 2026 17:34
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

LCM Tests

    16 files  ±0      16 suites  ±0   3m 1s ⏱️ -1s
 2 851 tests ±0   2 831 ✅ ±0   20 💤 ±0  0 ❌ ±0 
11 352 runs  ±0  11 184 ✅ ±0  168 💤 ±0  0 ❌ ±0 

Results for commit 0763a7e. ± Comparison against base commit 2283e93.

♻️ This comment has been updated with latest results.

Change-Id: I803453545dbf7494c9e2f9ee0e9a5c1324e692e3
@papeh papeh marked this pull request as ready for review February 6, 2026 21:45
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion.

@jasonleenaylor
Copy link
Contributor

Yes, I think it is still useful, I got what I needed out of it locally and put it in for a possible future need. No urgency but it will probably help debugging if we start working to improve multi-user lcm usage.

@jasonleenaylor jasonleenaylor merged commit f9a164a into master Feb 6, 2026
7 of 8 checks passed
@papeh papeh deleted the develop branch February 6, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants