Conversation
github-actions
bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
myieye
force-pushed
the
copilot/fix-filter-field-uppercase
branch
from
e40c961 to
d9f9d01
Compare
myieye
changed the title
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| className, | ||
| )} | ||
| bind:ref | ||
| autocapitalize="off" |
There was a problem hiding this comment.
❓ Is it intentional to have spellcheck="false" in both input.svelte and textarea.svelte, but not here in command-input.svelte (which is used in multi-select and select)?
| bind:value={customExampleProjectName} | ||
| placeholder={$t`Project name...`} | ||
| onclick={(e) => e.stopPropagation()} | ||
| autocapitalize="on" |
There was a problem hiding this comment.
One of these things is not like the others. Was it intended here?
Autocapitalize=off is a reasonable default for our app.
Essentially all of our test fields are either data fields or fields for filtering by that data.
Arguably fields like Note or the Semantic domain filter should use autocapitalize, but instead of fine-tuning now, I want to just set the better global default.