Skip to content

Add typechecking to linting#8

Open
imnasnainaec wants to merge 1 commit intomainfrom
typecheck
Open

Add typechecking to linting#8
imnasnainaec wants to merge 1 commit intomainfrom
typecheck

Conversation

@imnasnainaec
Copy link
Contributor

@imnasnainaec imnasnainaec commented Feb 6, 2026

Fixes #7

Also adds a script to the paranext-core's stop.


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Enhanced development tooling with improved type-checking validation in the build process
    • Added utility script for managing the development environment

@imnasnainaec imnasnainaec self-assigned this Feb 6, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Feb 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Added TypeScript type checking to the lint workflow by introducing a lint:typecheck script that runs tsc --noEmit, updating the main lint script to execute this check, and configuring tsconfig to skip library declaration file validation.

Changes

Cohort / File(s) Summary
Lint Configuration
package.json
Added stop script and new lint:typecheck script using TypeScript compiler. Updated main lint script to include type checking alongside existing lint checks.
TypeScript Configuration
tsconfig.json
Added skipLibCheck: true to compiler options to skip type-checking of declaration files in dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A typecheck hop through our code so bright,
Where errors now fail the lint, done right!
No more hiding imports gone astray,
TypeScript catches them every day!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The addition of a stop script is out-of-scope and unrelated to the linked issue #7 which focuses solely on type-checking failures in linting. Remove the 'stop' script addition from package.json as it is unrelated to fixing the type-checking linting issue described in issue #7.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding TypeScript type-checking to the linting process.
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #7 by adding TypeScript type-checking to npm run lint so it fails on .tsx file errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch typecheck

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint not failing when our .tsx files have ts issues.

1 participant