(On hold) Bugfix: Correct example sentence magic string#110
Open
(On hold) Bugfix: Correct example sentence magic string#110
Conversation
When reviewing code on a different PR, I noticed that the value of LFFieldNameForExampleSentence was set to definition. This looks wrong and is likely the result of a copy/paste error (from the line above). I have no way to test this, and this PR doesn't fix a known bug. However, it seems so obviously wrong that I got up the guts to create this PR :)
Collaborator
|
The one thing holding me back from merging this is that I want to check the Mongo database on QA (and live) to see if any migration script is needed. If we don't run a migration script, the worst that would happen is that some people's comments might show up in the wrong part of the entry, so that's not too bad. |
rmunn
changed the title
Collaborator
|
I may be able to get to this one before I leave, but I'm marking it as "On hold" in case I don't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing code on a different PR, I noticed that the value of
LFFieldNameForExampleSentencewas set todefinitionwhen it most definitely should be set tosentence. This looks wrong and is likely the result of a copy/paste error (from the line above). I have no way to test this, and this PR doesn't fix a known bug. However, it seems so obviously wrong that I got up the guts to create this PR :)Fixes #109
References in web-languageforge to support this PR:
This change is