Skip to content

Conversation

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated the build and publishing workflow to execute library compilation as an explicit step
    • Configured release tags to follow semantic versioning format

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

The publish workflow is refactored to explicitly build the library as a GitHub Actions step rather than relying on npm's prepublishOnly hook. A release-plan configuration is added to the shepherd project to specify the tag format for releases.

Changes

Cohort / File(s) Summary
Build workflow step
.github/workflows/publish.yml
Added "Build library" step executing npm run build_lib after npm ci and before NPM publish.
Root build script
package.json
Removed prepublishOnly script entry from the scripts object.
Release configuration
projects/shepherd/package.json
Added release-plan object with tagFormat field set to "v${version}" for release tagging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With workflows refined and scripts set free,
The build now happens in CI, you see!
From hooks to steps, we chart the way,
Release tags bloom in format's display! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'More release-plan fixes' is vague and generic, using non-descriptive language that doesn't clearly convey the specific changes made to the workflow, build process, or release configuration. Consider a more specific title that describes the main change, such as 'Move build step from prepublishOnly to GitHub Actions workflow' or 'Refactor build process and add release-plan configuration'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4892c0 and 852e932.

📒 Files selected for processing (3)
  • .github/workflows/publish.yml
  • package.json
  • projects/shepherd/package.json
💤 Files with no reviewable changes (1)
  • package.json
🔇 Additional comments (2)
projects/shepherd/package.json (1)

33-35: LGTM!

The release-plan configuration with tagFormat: "v${version}" is correctly structured and follows the standard versioning tag pattern (e.g., v21.0.0).

.github/workflows/publish.yml (1)

35-36: The build_lib script is properly defined in package.json.

The explicit build step is a good approach, making the CI pipeline more transparent than relying on npm lifecycle hooks. The script correctly runs ng build shepherd.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/publish.yml (1)

37-40: Missing NODE_AUTH_TOKEN for npm publishing.

The workflow sets up the npm registry (line 33) but doesn't provide NODE_AUTH_TOKEN in the environment for the publish step. Without this, publishing to npm will fail with an authentication error.

🔧 Proposed fix
       - name: Publish to NPM
         run: npx release-plan publish --provenance
         env:
           GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Ensure that NPM_TOKEN (or your equivalent secret name) is configured in the repository secrets.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4892c0 and 852e932.

📒 Files selected for processing (3)
  • .github/workflows/publish.yml
  • package.json
  • projects/shepherd/package.json
💤 Files with no reviewable changes (1)
  • package.json
🔇 Additional comments (2)
projects/shepherd/package.json (1)

33-35: LGTM!

The release-plan configuration with tagFormat: "v${version}" is correctly structured and follows the standard versioning tag pattern (e.g., v21.0.0).

.github/workflows/publish.yml (1)

35-36: The build_lib script is properly defined in package.json.

The explicit build step is a good approach, making the CI pipeline more transparent than relying on npm lifecycle hooks. The script correctly runs ng build shepherd.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@RobbieTheWagner RobbieTheWagner merged commit 0d81ef1 into main Jan 14, 2026
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants