-
-
Notifications
You must be signed in to change notification settings - Fork 49
More release-plan fixes #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More release-plan fixes #2875
Conversation
📝 WalkthroughWalkthroughThe publish workflow is refactored to explicitly build the library as a GitHub Actions step rather than relying on npm's Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/publish.yml (1)
37-40: MissingNODE_AUTH_TOKENfor npm publishing.The workflow sets up the npm registry (line 33) but doesn't provide
NODE_AUTH_TOKENin the environment for the publish step. Without this, publishing to npm will fail with an authentication error.🔧 Proposed fix
- name: Publish to NPM run: npx release-plan publish --provenance env: GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}Ensure that
NPM_TOKEN(or your equivalent secret name) is configured in the repository secrets.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/publish.ymlpackage.jsonprojects/shepherd/package.json
💤 Files with no reviewable changes (1)
- package.json
🔇 Additional comments (2)
projects/shepherd/package.json (1)
33-35: LGTM!The
release-planconfiguration withtagFormat: "v${version}"is correctly structured and follows the standard versioning tag pattern (e.g.,v21.0.0)..github/workflows/publish.yml (1)
35-36: Thebuild_libscript is properly defined in package.json.The explicit build step is a good approach, making the CI pipeline more transparent than relying on npm lifecycle hooks. The script correctly runs
ng build shepherd.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.