Fixed documentation strings so the docs site can build#44
Open
yougotwill wants to merge 1 commit intosession-foundation:devfrom
Open
Fixed documentation strings so the docs site can build#44yougotwill wants to merge 1 commit intosession-foundation:devfrom
yougotwill wants to merge 1 commit intosession-foundation:devfrom
Conversation
Bilb
approved these changes
Apr 17, 2025
Member
|
I opened #45 as an alternative to this that fixes the issues in the parser. |
jagerman
reviewed
Apr 17, 2025
| /// separately retain metadata about *completed* multipart sets (see MULTIPART_MAX_REMEMBER). | ||
| /// | ||
| /// Inputs: None | ||
| /// |
Member
There was a problem hiding this comment.
This is caused by missing /// Member variable. (fixed in #45)
jagerman
reviewed
Apr 17, 2025
| /// (final) config hash and timestamp of the recombined parts needed for deduplication. | ||
| /// | ||
| /// Inputs: None | ||
| /// |
jagerman
reviewed
Apr 17, 2025
| /// encrypt(m).size(). | ||
| /// | ||
| /// Inputs: None | ||
| /// |
Member
There was a problem hiding this comment.
This one is indeed a parser problem; I've added a change in #45 that recognizes this as a constant automatically, but also adds a new /// Constant. stanza in cases where the constant might be too complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constexprthe documentation builder still expects the docstring to haveInputs: None. We should probably update the script<const unsigned char>. The regex forRPC_STARTin the build script does not account for spaces. I tried tweaking it but it broke other things. So this is the current solution which I have seen elsewhere in the code base.