ported timeoutTicker fix from 6.2.0

[pompon0]

Ported sei-protocol/sei-tendermint#331

[codecov]

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.56%. Comparing base (2c746c3) to head (8d85be0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sei-tendermint/libs/service/service.go	0.00%	3 Missing ⚠️

❌ Your project status has failed because the head coverage (47.23%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files        1543     1543           
  Lines      156818   156828   +10     
=======================================
+ Hits        80856    80865    +9     
- Misses      69861    69862    +1     
  Partials     6101     6101           

Flag	Coverage Δ
sei-chain	27.51% <0.00%> (+<0.01%)	⬆️
sei-cosmos	51.64% <ø> (+<0.01%)	⬆️
sei-tendermint	58.57% <86.95%> (+<0.01%)	⬆️
sei-wasmd	51.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-tendermint/internal/consensus/state.go	70.61% <100.00%> (-0.15%)	⬇️
sei-tendermint/internal/consensus/ticker.go	100.00% <100.00%> (ø)
sei-tendermint/libs/service/service.go	55.71% <0.00%> (-0.81%)	⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[masih]

use testify since the repo depends on it already and other tests use it?

[pompon0]

there are 2 problems with testify:

• it is weakly typed (I've provided strongly typed wrapper in sei-tendermint/libs/utils/require)
• require package works only from the test's main goroutine (same as t.Fatal though), assert package is a wrapper on t.Errorf which reports errors lazily (the test actually continues after t.Errorf call, which obfuscates error - extra logs, potential deadlocks, cascading errors).

Hence, I prefer regular error passing (or optionally panics for test helpers, for which error passing gets too verbose). The final t.Fatal call is just for reporting the error back to the testing harness.

[masih]

OK thanks for explaining.

Would be nice to maintain less custom code and converge on using existing popular enough libraries maintained by someone other than us 😅

But both approaches work.