Conversation
maretskiy
force-pushed
the
set-of-small-fixes
branch
from
4aa3180 to
407a6d9
Compare
|
@maretskiy I merged another patch seems like we can close this one |
| except Exception as e: | ||
| LOG.error(("Backend '{}' driver '{}' " | ||
| "error: {}").format(backend, drv_name, e)) | ||
| LOG.error("Backend '{}' driver '{}': {}: {}".format( |
There was a problem hiding this comment.
logging itself formats the string and you should not do it explicitly because logging does it according to the specified level and can skip the formatting if it is not necessary. So, instead of
LOG.error("Backend '{}' driver '{}': {}: {}".format(backend, drv_name, type(e), e))
you should do:
LOG.error("Backend '%s' driver '%s': %s: %s", backend, drv_name, type(e), e)
Unfortunately, logging does not support the format style by default.
There was a problem hiding this comment.
I changed all such occurrences in seecloud/availability#24 and other projects as well.
| "*": {"type": "object"} | ||
| } | ||
| }, | ||
| "logging": { |
There was a problem hiding this comment.
I would suggest not to add this functionality right now and do it properly later by dying the appropriate configuration of logging throught fileConfig or dictConfig in oss-lib.
There was a problem hiding this comment.
This commit is already merged by another pull request (as dependency) so let's fix this later during integration with oss-lib
4 participants
No description provided.