Remove pure-sasl dependency by implementing internal SASL client #685
+393
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
dkropachev
force-pushed
the
remove-pure-sasl-dependency
branch
2 times, most recently
from
0dece76 to
6029c30
Compare
This change eliminates the external pure-sasl dependency which has been unmaintained since 2019 (addresses #666). The implementation provides: - Internal SASL client in cassandra/sasl.py based on pure-sasl (MIT licensed) - Full PLAIN mechanism support for username/password authentication - Full GSSAPI mechanism support for Kerberos authentication with QOP negotiation - Platform-aware kerberos library selection (kerberos/winkerberos) The internal implementation maintains API compatibility with existing code while removing the risk of depending on an unmaintained external library.
dkropachev
force-pushed
the
remove-pure-sasl-dependency
branch
from
6029c30 to
fb19b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pure-sasldependency with an internal SASL client implementationpure-saslFixes #666
Background
The
pure-saslpackage has been unmaintained since 2019. While it currently works, depending on an unmaintained library poses risks for future Python version compatibility and security issues.Changes
New
cassandra/sasl.pymodule: Internal SASL client implementation based onpure-sasl(MIT licensed) with full support for:Updated
cassandra/auth.py:SASLClientfrom internal module instead ofpuresasl_have_puresaslchecks (SASL is now always available)cassandra.sasl.QOPinstead ofpuresasl.QOPUpdated
pyproject.toml: Removedpure-saslfrom dev dependenciesUpdated
docs/security.rst: Removed references topure-saslpackageUpdated tests:
pure-saslskip check from integration testsTest plan
pytest tests/unit/test_auth.py -vVerify GSSAPI mechanism works with Kerberos environment