CLDSRV-830: Fix NaN serialization as null in access logs #6047

dvasilas · 2026-01-16T16:54:36Z

Server access logs contain explicit null values for bytesReceived and contentLength when parsedContentLength is NaN.
Example seen in lab:

{
  "time": 1768576073,
  "hostname": "dvasilas-L06-store-5",
  "pid": 83,
  "action": "GetObject",
  "accountName": "dimitrios1",
  "httpMethod": "GET",
  "bytesReceived": null,
  "contentLength": null,
  "elapsed_ms": 21.807304,
  "startTime": "1768576073.554",
  "requester": "8b387b04a1e78cc47adb274f2d72aba9251fd508d8bd013eb10e70929833b4d6",
  "operation": "REST.GET.OBJECT",
  "requestURI": "GET /dest-bucket/test-bucket/2026-01-16-15-07-07-4910BC5BA5CFB61C HTTP/1.1",
  "objectSize": 509,
  "totalTime": "21",
  "turnAroundTime": "14",
  "userAgent": "aws-cli/1.29.62 md/Botocore#1.31.62 ua/2.0 os/linux#5.14.0-570.17.1.el9_6.x86_64 md/arch#x86_64 lang/python#3.9.25 md/pyimpl#CPython cfg/retry-mode#legacy botocore/1.31.62",
  "signatureVersion": "SigV4",
  "authenticationType": "AuthHeader",
  "hostHeader": "127.0.0.1:8080",
  "bucketOwner": "8b387b04a1e78cc47adb274f2d72aba9251fd508d8bd013eb10e70929833b4d6",
  "bucketName": "dest-bucket",
  "req_id": "95657259fa46b201d0cd",
  "bytesSent": 509,
  "clientIP": "10.160.120.10",
  "httpCode": 200,
  "objectKey": "test-bucket/2026-01-16-15-07-07-4910BC5BA5CFB61C",
  "logFormatVersion": "0",
  "loggingEnabled": false,
  "awsAccessKeyID": "1J1U8SORZL163A7MNPPC",
  "raftSessionID": 5
}

This happens when Number.parseInt('', 10) returns NaN, which JSON.stringify then serializes as null instead of omitting the field.

bert-e · 2026-01-16T16:54:40Z

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-01-16T16:54:46Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-830 contains:

9.2.15

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.2.15
9.3.0

Please check the Fix Version/s of CLDSRV-830, or the target
branch of this pull request.

codecov · 2026-01-16T16:55:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (c022d57) to head (23e383a).
⚠️ Report is 7 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/utilities/serverAccessLogger.js	`76.47% <ø> (ø)`

@@               Coverage Diff                @@
##           development/9.2    #6047   +/-   ##
================================================
  Coverage            84.35%   84.35%           
================================================
  Files                  206      206           
  Lines                12997    12997           
================================================
  Hits                 10964    10964           
  Misses                2033     2033

Flag	Coverage Δ
file-ft-tests	`67.40% <ø> (ø)`
kmip-ft-tests	`28.12% <ø> (ø)`
mongo-v0-ft-tests	`68.65% <ø> (ø)`
mongo-v1-ft-tests	`68.64% <ø> (-0.03%)`	⬇️
multiple-backend	`35.28% <ø> (ø)`
sur-tests	`35.63% <ø> (-0.78%)`	⬇️
sur-tests-inflights	`37.41% <ø> (-0.04%)`	⬇️
unit	`69.94% <ø> (ø)`
utapi-v2-tests	`34.29% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tmacro · 2026-01-16T18:38:59Z

lib/utilities/serverAccessLogger.js

        httpMethod: req.method ?? undefined,
        bytesDeleted: params.analyticsBytesDeleted ?? undefined,
-        bytesReceived: req.parsedContentLength ?? undefined,
+        bytesReceived: Number.isNaN(req.parsedContentLength) ? undefined : (req.parsedContentLength ?? undefined),


Suggested change

bytesReceived: Number.isNaN(req.parsedContentLength) ? undefined : (req.parsedContentLength ?? undefined),

bytesReceived: Number.isInteger(req.parsedContentLength) ? req.parsedContentLength : undefined,

could also flip the check

Server access logs contain explicit null values for bytesReceived and contentLength when parsedContentLength is NaN. This happens when Number.parseInt('', 10) returns NaN, which JSON.stringify then serializes as null instead of omitting the field. Add Number.isNaN() checks to convert NaN to undefined, allowing JSON.stringify to omit these fields as intended.

dvasilas · 2026-01-19T05:44:49Z

/approve

bert-e · 2026-01-19T05:44:58Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-830 contains:

9.2.15

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.2.15
9.3.0

Please check the Fix Version/s of CLDSRV-830, or the target
branch of this pull request.

The following options are set: approve

dvasilas · 2026-01-19T06:17:52Z

🤖

bert-e · 2026-01-19T06:18:08Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/bugfix/CLDSRV-830 with contents from bugfix/CLDSRV-830
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/bugfix/CLDSRV-830 origin/development/9.3
 git merge origin/bugfix/CLDSRV-830
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/bugfix/CLDSRV-830

The following options are set: approve

dvasilas · 2026-01-19T06:24:52Z

🤖

bert-e · 2026-01-19T06:46:38Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.2
✔️ development/9.3

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2026-01-19T07:08:34Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.2
✔️ development/9.3

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

Please check the status of the associated issue CLDSRV-830.

Goodbye dvasilas.

leif-scality approved these changes Jan 16, 2026

View reviewed changes

tmacro approved these changes Jan 16, 2026

View reviewed changes

tmacro reviewed Jan 16, 2026

View reviewed changes

BourgoisMickael approved these changes Jan 16, 2026

View reviewed changes

dvasilas added 2 commits January 19, 2026 07:44

CLDSRV-830: Bump version to 9.2.15

23e383a

dvasilas force-pushed the bugfix/CLDSRV-830 branch from c575008 to 23e383a Compare January 19, 2026 05:44

bert-e merged commit efcecb9 into development/9.2 Jan 19, 2026
29 checks passed

bert-e deleted the bugfix/CLDSRV-830 branch January 19, 2026 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CLDSRV-830: Fix NaN serialization as null in access logs #6047

CLDSRV-830: Fix NaN serialization as null in access logs #6047

dvasilas commented Jan 16, 2026

Uh oh!

bert-e commented Jan 16, 2026

Uh oh!

bert-e commented Jan 16, 2026

Uh oh!

codecov bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

tmacro Jan 16, 2026

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	bytesReceived: Number.isNaN(req.parsedContentLength) ? undefined : (req.parsedContentLength ?? undefined),
	bytesReceived: Number.isInteger(req.parsedContentLength) ? req.parsedContentLength : undefined,

CLDSRV-830: Fix NaN serialization as null in access logs #6047

CLDSRV-830: Fix NaN serialization as null in access logs #6047

Conversation

dvasilas commented Jan 16, 2026

Uh oh!

bert-e commented Jan 16, 2026

Hello dvasilas,

Uh oh!

bert-e commented Jan 16, 2026

Incorrect fix version

Uh oh!

codecov bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tmacro Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Incorrect fix version

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

Conflict

Uh oh!

dvasilas commented Jan 19, 2026

Uh oh!

bert-e commented Jan 19, 2026

In the queue

Uh oh!

bert-e commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jan 16, 2026 •

edited

Loading