Fixes #195 - improved retcode handling#196
Open
jmarinaro wants to merge 1 commit intosaltstack:developfrom
Open
Fixes #195 - improved retcode handling#196jmarinaro wants to merge 1 commit intosaltstack:developfrom
jmarinaro wants to merge 1 commit intosaltstack:developfrom
Conversation
Contributor
|
Howdy! 👋 Apologies for the long delay on this integrating this code. We certainly appreciate your effort! Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met. If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR. If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR. Thank you, and we hope to see you active in the Salt ecosystem in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #195
The runner client does not properly pass through exit codes from the salt master due to a mismatch of the expected data structure. The fix uses recursion to find all instances of
retcodein the return data.