Skip to content

Conversation

@cristi-
Copy link
Member

@cristi- cristi- commented Jan 16, 2026

Summary

  • Rename submodule from protos to s2-specs
  • Update submodule URL to s2-specs repository
  • Update update_protos script to use new submodule path

Test plan

  • Verify submodule points to s2-specs
  • Verify ./update_protos script works with new path

🤖 Generated with Claude Code

@cristi- cristi- requested a review from a team as a code owner January 16, 2026 15:33
@greptile-apps
Copy link

greptile-apps bot commented Jan 16, 2026

Greptile Summary

Renames the submodule from protos to s2-specs to align with the new repository naming convention, and adds automated sync workflow.

  • Renamed git submodule from protos to s2-specs and updated URL to point to new repository
  • Updated update_protos script to reference new submodule path
  • Added sync_specs.yaml workflow to automatically sync submodule updates via repository dispatch events and create PRs with signed commits

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward refactoring (renaming submodule) and adding automation. All references were correctly updated. Minor deduction for new workflow that should be tested in practice to ensure proper operation
  • Pay close attention to .github/workflows/sync_specs.yaml to verify it triggers correctly on s2-specs-update events

Important Files Changed

Filename Overview
.gitmodules Renamed submodule from protos to s2-specs with updated repository URL
update_protos Updated script to reference new s2-specs submodule path instead of protos
.github/workflows/sync_specs.yaml New workflow to auto-sync submodule updates and create PRs with signed commits

Sequence Diagram

sequenceDiagram
    participant S2Specs as s2-specs repo
    participant Dispatch as Repository Dispatch
    participant Workflow as sync_specs.yaml
    participant Submodule as s2-specs submodule
    participant Script as update_protos
    participant PR as Pull Request

    S2Specs->>Dispatch: Trigger s2-specs-update event
    Dispatch->>Workflow: Start workflow
    Workflow->>Workflow: Checkout with submodules
    Workflow->>Submodule: Update s2-specs submodule
    alt Submodule was updated
        Workflow->>Workflow: Setup uv
        Workflow->>Script: Run ./update_protos
        Script->>Script: Regenerate proto files
        Workflow->>PR: Create signed commit PR
        PR->>PR: PR created with s2-helper[bot]
    else No submodule changes
        Workflow->>Workflow: Skip remaining steps
    end
Loading

- Rename submodule from protos to s2-specs
- Update submodule URL to s2-specs repository
- Update update_protos script to use new submodule path

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@cristi- cristi- changed the title chore: migrate submodule to s2-specs and add sync workflow chore: migrate submodule from protos to s2-specs Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants