Open
Conversation
GuillaumeGomez
force-pushed
the
simplify-tests
branch
from
cbdb3ee to
9052259
Compare
antoyo
reviewed
Feb 6, 2026
tests/lang_tests.rs
Outdated
| @@ -0,0 +1,148 @@ | |||
| //! The common code for `tests/lang_tests_*.rs` | |||
Contributor
There was a problem hiding this comment.
Remove this comment please.
tests/lang_tests.rs
Outdated
| ]); | ||
|
|
||
| let mut parts = compile_and_run_cmds(debug_args, &test_target, &exe); | ||
| for part in compile_and_run_cmds(compiler_args, &test_target, &exe) { |
Contributor
There was a problem hiding this comment.
Can you please add a comment to make it clearer that the args are different for debug vs release and rename compiler_args to release_args or something?
tests/lang_tests.rs
Outdated
Comment on lines
142
to
144
| for part in compile_and_run_cmds(compiler_args, &test_target, &exe) { | ||
| parts.push(part); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| for part in compile_and_run_cmds(compiler_args, &test_target, &exe) { | |
| parts.push(part); | |
| } | |
| parts.extend(compile_and_run_cmds(compiler_args, &test_target, &exe)); |
GuillaumeGomez
force-pushed
the
simplify-tests
branch
from
9052259 to
e82a7be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.