Open
Conversation
cc2bbb8 to
3f1304a
Compare
Contributor
|
For the test, you can either add it to this file or you can create another file in that directory. |
Contributor
|
Did you want to add a test or would you want to merge this as is? |
Contributor
Author
|
I did try to add a test and found that the test passes either way, so maybe I should change the PR to just add the test instead of changing the code? |
Contributor
|
You mean, to make sure the test fails without the implementation of int extension? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix the FIXME in
zext. Would this be acceptable?Also, how should I add tests?