ci: switch to cargo-fuzz from honggfuzz#853
Open
apoelstra wants to merge 6 commits intorust-bitcoin:masterfrom
Open
ci: switch to cargo-fuzz from honggfuzz#853apoelstra wants to merge 6 commits intorust-bitcoin:masterfrom
apoelstra wants to merge 6 commits intorust-bitcoin:masterfrom
Conversation
This lint appears when running the stable compiler, not just clippy. We don't pin the stable compiler version, so this has started showing up in CI, which is a bit noisy.
apoelstra
force-pushed
the
2025-09/fuzz
branch
2 times, most recently
from
fe02d08 to
d3fd35c
Compare
Member
Author
|
My local CI is failing on this. Investigating. |
Member
Author
|
The issue seems to be with nightly-2025-03-21, which this crate is stuck on since #805 isn't passing. I will add some commits which update to the latest nightly here. |
I'm not sure if it's possible to link to .md files in the source code. If so, this isn't the way to do it.
apoelstra
force-pushed
the
2025-09/fuzz
branch
2 times, most recently
from
454afe7 to
79deb4a
Compare
TBH I had thought we'd fixed these years ago..
apoelstra
force-pushed
the
2025-09/fuzz
branch
2 times, most recently
from
09c4d53 to
928520a
Compare
honggfuzz is increasingly hard for me to maintain in my local CI. It requires an exact match between the version of honggfuzz in the lockfile and the binary installed in the nix derivation, and these exact versions come with specific requirements about which rustc versions are allowable (and in particular, honggfuzz 0.5.56 does not work with rustc 1.74.0, which is the MSRV for rust-bitcoin). I also have to bend over backward to set compiler flags and make source directories writable. cargo-fuzz, meanwhile, requires nightly to *run* the fuzz tests, but does not require it for just running unit tests or building. (The latest version of libfuzzer-sys uses once_cell and requires a higher MSRV than we have, but we don't need to use the very latest version.)
apoelstra
force-pushed
the
2025-09/fuzz
branch
from
928520a to
49427d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
honggfuzz is increasingly hard for me to maintain in my local CI. It requires an exact match between the version of honggfuzz in the lockfile and the binary installed in the nix derivation, and these exact versions come with specific requirements about which rustc versions are allowable (and in particular, honggfuzz 0.5.56 does not work with rustc 1.74.0, which is the MSRV for rust-bitcoin). I also have to bend over backward to set compiler flags and make source directories writable.
Once we get this working here, I will open the same PR to rust-bitcoin. But I wanted to start here because it's an easier crate to maintain and also our fuzztests are in much better shape.