Draft
Conversation
`bitcoind-tests` has a dependency on `bitcoin` so it makes depending on a local patched version more difficult, just temporarily delete it.
tcharding
force-pushed
the
crate-smashing
branch
from
80cf6c1 to
96dce49
Compare
Depend on the `crate-smashing` branch, which introduces the new `primitives`, `bip32`, and `psbt-v0` crates. The point of this patch is to try to show we have all the re-exports correct in `rust-bitcoin` after introducing the new crates. Apart from the manifest changes this patch changes a single line, BOOM!
tcharding
force-pushed
the
crate-smashing
branch
from
96dce49 to
1a898e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo what is needed to depend on the new
primitives,psbt-v0, andbip32crates. Note the patch separation so its obvious what is going on.This PR is massive in how simple it is. FTR almost all the changes could be removed by using
use bitcoin_primitives as bitcoinin the manifest but I thought that is too much magic for just now.Uses rust-bitcoin/rust-bitcoin#2883