Skip to content

Add 'all' recipe to justfile#509

Draft
APonce911 wants to merge 1 commit intorust-bitcoin:masterfrom
APonce911:update-justfile
Draft

Add 'all' recipe to justfile#509
APonce911 wants to merge 1 commit intorust-bitcoin:masterfrom
APonce911:update-justfile

Conversation

@APonce911
Copy link

Include a new Just Recipe to run all other recipes.
Useful to run locally before opening the pull request for review.

to run:
just all

@tcharding
Copy link
Member

This is kind of like just sane in rust-bitcoin

# Quick workspace sanity check.
@sane: lint
  cargo test --quiet --workspace --all-targets --no-default-features
  cargo test --quiet --workspace --all-targets --all-features

Note how we can define sane to call lint using the : syntax.

I'm not adverse to adding a just sane command here. I'm not super keen on a just all because I don't know when its useful to run everything eg updating the lock files is usually a planned action, not just on every PR.

Copy link
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be better to add just sane. It keeps it in line with rust-bitcoin and commands like fmt and update-lock-files change the code so are better run separately as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments