Update latest master #925
Closed
Update latest master #925
+663
−388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-module rules (#912) Co-authored-by: automergerpr-permission-manager[bot] <190534181+automergerpr-permission-manager[bot]@users.noreply.github.com>
This PR adds the [volatile_store](https://doc.rust-lang.org/std/intrinsics/fn.volatile_store.html) intrinsic. For this semantics, memory being "volatile" is meaningless as the we are not compiling any further, and aren't modeling any compiler optimisations that could occur if we were to. Therefore this is implemented as a simple dereference of the pointer and store of the value provided at that location.
The staged function evaluation created issues with the SMT solver (unevaluated terms could contain `#lookupDiscriminant` calls while the path condition held `#lookupDiscrAux` constraints). Making the first evaluation step a rewrite changes the step counters but avoids this problem altogether because rewrite symbols don't normally go to the SMT solver.
Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: devops <devops@runtimeverification.com>
Collaborator
Author
|
I couldn't figure out how to make CI run on the tip of feature/p-token again after I pushed the fix so I just opened this again #926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_parse_args#918volatile_storeintrinsic #919kmir._prove#920