Conversation
Fixes #7908
fitzn
left a comment
fitzn
left a comment
There was a problem hiding this comment.
Just a few suggestions on the initial pass. I can take another look when this is ready for review.
|
|
||
| You can automatically install all missing dependencies by passing in the install flag | ||
| ``` | ||
| $ ./local/check-dependencies.sh install |
There was a problem hiding this comment.
I think we should make this --install to make it more clear that this is a toggle/flag.
| $ ./local/install-dependency-3proxy.sh | ||
| ``` | ||
|
|
||
| You can automatically install all missing dependencies by passing in the install flag |
|
|
||
| echo -ne "${Name}: " | ||
| if [ $Missing ]; then failed ; else passed ; fi | ||
| if [ $Missing ] && [ $AutoInstall ] && [ $AutoInstall == "install" ]; |
There was a problem hiding this comment.
You don't need the middle clause because all variables will be the empty string until defined. So, the second clause can be [ "$AutoInstall" == "--install" ]; then
| if [ $Missing ] && [ $AutoInstall ] && [ $AutoInstall == "install" ]; | ||
| then install $Name ; | ||
| elif [ $Missing ]; | ||
| then failed ; |
There was a problem hiding this comment.
Our default syntax in other scripts is for the then to be on the preceding line after the semi-colon.
|
@khsheehan I removed the ticket reference since it was for the other repository. You can make a new issue in this repository if you want, but I don't think it's strictly necessary. |
2 participants
No description provided.