Honor concurrent_downloads from .gemrc in Gem::ConfigFile#9339
Merged
colby-swandale merged 1 commit intoruby:masterfrom Feb 19, 2026
Merged
Honor concurrent_downloads from .gemrc in Gem::ConfigFile#9339colby-swandale merged 1 commit intoruby:masterfrom
colby-swandale merged 1 commit intoruby:masterfrom
Conversation
colby-swandale
approved these changes
Feb 19, 2026
Member
colby-swandale
left a comment
There was a problem hiding this comment.
Nice and easy! Thanks!
We'll probably need to update https://guides.rubygems.org/command-reference/ also, but that will need to be a separate PR.
Member
Author
Thank you! I have created a separate PR for guides. #9341 |
colby-swandale
added a commit
that referenced
this pull request
Feb 20, 2026
…-reference Document :concurrent_downloads in gem environment config docs (follow-up to #9339)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
concurrent_downloadsvalues configured in.gemrcwere ignored duringGem::ConfigFileinitialization.Even with
concurrent_downloads: 2in config, RubyGems kept using the default value (8).This made
.gemrcbehavior inconsistent with other config options (likeverbose,update_sources, etc.) that are properly applied.What is your fix for the problem, implemented in this PR?
I added a regression test to reproduce the issue:
test_initialize_concurrent_downloadswritesconcurrent_downloads: 2to a config fileGem::ConfigFile@cfg.concurrent_downloads == 2Before the fix, that test failed (
expected 2, got 8).Root cause:
concurrent_downloadswas not included in the key normalization list that converts config keys to symbols@hashduring initializationFix implemented:
concurrent_downloadsin the transform-to-symbol allowlist@concurrent_downloads = @hash[:concurrent_downloads]when presentI chose this approach because it matches the existing pattern used for other RubyGems config options, keeps behavior consistent, and is minimal/risk-contained.
Make sure the following tasks are checked