Patch ActionDispatch::DebugExceptions to capture NotFound exceptions#252
Open
wjordan wants to merge 3 commits intoroidrage:masterfrom
Open
Patch ActionDispatch::DebugExceptions to capture NotFound exceptions#252wjordan wants to merge 3 commits intoroidrage:masterfrom
wjordan wants to merge 3 commits intoroidrage:masterfrom
Conversation
wjordan
force-pushed
the
debug_exceptions
branch
from
7395f36 to
e2b703a
Compare
publish errors to Notifications instead of logging the full backtrace directly.
wjordan
force-pushed
the
debug_exceptions
branch
from
e2b703a to
eea2ff7
Compare
wjordan
force-pushed
the
debug_exceptions
branch
from
0e15376 to
8d55ad5
Compare
Collaborator
|
@wjordan this looks like a great change! Can you rebase on master so the latest CI will run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches
ActionDispatch::DebugExceptionsto capture those pesky hard-codedActionController::RoutingErrorexceptions generated by non-route-matchingX-Cascade == 'pass'responses, re-publishing them to theActiveSupport::Notificationsbus where they are cleanly logged byLograge, instead of automatically writing a full exception backtrace directly to the Rails log.Fixes #27, #142.
No tests yet other than running manually in my project- could use guidance on the best way to cover this.