bugfix the (non)existence of a slash when staticFolder is set#27
Open
coderofsalvation wants to merge 1 commit intoreddec:masterfrom
Open
bugfix the (non)existence of a slash when staticFolder is set#27coderofsalvation wants to merge 1 commit intoreddec:masterfrom
coderofsalvation wants to merge 1 commit intoreddec:masterfrom
Conversation
Owner
|
@coderofsalvation thanks for the idea, I used it as basis in d2e405c . Could you please confirm that it will solve your case? |
57e5a15 to
c3bb29c
Compare
Author
|
yup that works! |
reddec
requested changes
Dec 29, 2023
Comment on lines
+197
to
+201
| dir, err := f.Readdir(1) | ||
| if len(dir) > 0 { | ||
| f.Close() | ||
| return local.writeStaticFile( path + "/index.html", out ) | ||
| } |
Owner
There was a problem hiding this comment.
It feels like Readdir here is overkill 😺
Could you please use something like this
if _, err := os.Stat("/path/to/whatever"); errors.Is(err, os.ErrNotExist) {
// path/to/whatever does not exist
}Also, for path concatenation it's better to use filepath.Join - it will take care of few corner cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so, as @reddec already expected the staticDir crashed when no trailing space existed in an URL.
This fix handles all possible situations: