remove old workaround for compilation

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

Release Notes

• Chores

  • Updated test snapshots to reflect current performance metrics
  • Reorganized import paths for better code structure
  • Updated internal libraries to reference newer interface versions

• Refactor

  • Removed deprecated placeholder contracts
  • Removed obsolete helper libraries no longer in use
  • Consolidated type references to latest stable versions

[coderabbitai]

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

This pull request reorganizes the deprecated interface directory structure with new v1/v2 versioning, removes legacy utility libraries (LibDeployerDiscoverable, LibEncodedDispatch), and upgrades core evaluable types from EvaluableV2/V3 to EvaluableV4 alongside interface versions IInterpreterV4/IInterpreterStoreV3.

Changes

Cohort / File(s)	Summary
Interface Import Reorganization src/interface/IInterpreterCallerV4.sol, src/interface/IInterpreterStoreV3.sol, src/interface/IInterpreterV4.sol, src/interface/IParserV2.sol, src/interface/ISubParserV4.sol	Updated import paths to new deprecated v1/v2 subdirectory structure (e.g., from ../IInterpreterV3.sol to ./deprecated/v2/IInterpreterV3.sol).
Deprecated Interface Files src/interface/deprecated/v1/IExpressionDeployerV3.sol, src/interface/deprecated/v1/IExpressionDeployerV4.sol, src/interface/deprecated/v1/IInterpreterCallerV2.sol, src/interface/deprecated/v1/IInterpreterV2.sol, src/interface/deprecated/v2/IInterpreterCallerV3.sol, src/interface/deprecated/v2/IInterpreterExternV3.sol, src/interface/deprecated/v2/IInterpreterStoreV2.sol, src/interface/deprecated/v2/IInterpreterV3.sol, src/interface/deprecated/v2/ISubParserV3.sol	Migrated import paths within deprecated interfaces to align with new v1/v2 versioning hierarchy.
Error Contracts Removed src/error/ErrBytecode.sol, src/error/ErrExtern.sol	Deleted empty placeholder contract declarations and associated developer comments.
Core Library Type Upgrades src/lib/caller/LibContext.sol, src/lib/caller/LibEvaluable.sol, src/lib/ns/LibNamespace.sol	Updated to use new interface versions (IInterpreterV4, IInterpreterStoreV3) and upgraded LibEvaluable hash function to operate on EvaluableV4 instead of EvaluableV2.
Deprecated Library Removals src/lib/deprecated/caller/LibDeployerDiscoverable.sol, src/lib/deprecated/caller/LibEncodedDispatch.sol	Deleted entire deprecated utility libraries and their encoding/decoding logic.
Test Library Updates test/src/lib/caller/LibContextSlow.sol, test/src/lib/caller/LibEvaluableSlow.sol, test/src/lib/ns/LibNamespaceSlow.sol	Updated imports and function signatures to use new interface versions and EvaluableV4 type.
Test Contract Removals test/src/lib/caller/LibDeployerDiscoverable.t.sol, test/src/lib/deprecated/caller/LibEncodedDispatch.t.sol	Removed test files for deleted deprecated libraries.
Test Migration test/src/lib/caller/LibEvaluable.t.sol	Migrated all test functions from EvaluableV2/V3 variants to EvaluableV4, updated type parameters and test function names accordingly.
Gas Snapshots .gas-snapshot	Updated benchmark metrics reflecting new run counts and statistical parameters across multiple test suites.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• 2025 10 20 audit #93 — Main PR and related PR both introduce/switch to EvaluableV4 and IInterpreterV4/IInterpreterStoreV3 types, modifying core interpreter interface structures.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'remove old workaround for compilation' accurately describes a primary change—the removal of placeholder contracts ErrBytecode and ErrExtern that were compiler workarounds. However, the changeset includes substantial additional work (interface path reorganization, library updates, test migrations to V4) that represents significant portions of the diff.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 2026-02-11-audit

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/interface/IInterpreterCallerV4.sol (1)

38-38: ⚠️ Potential issue | 🟡 Minor

Stale NatSpec: references IInterpreterStoreV2 but should be IInterpreterStoreV3.

The interface comment on line 38 mentions IInterpreterStoreV2, but EvaluableV4 (line 27) uses IInterpreterStoreV3. This appears to be a pre-existing issue but worth fixing while you're touching this file.

📝 Suggested fix

-/// - OPTIONALLY set state on the associated `IInterpreterStoreV2`.
+/// - OPTIONALLY set state on the associated `IInterpreterStoreV3`.

[github-actions]

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

• Simple bug fixes, typos, or minor refactoring
• Single-purpose changes affecting 1-2 files
• Documentation updates
• Configuration tweaks
• Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

• Fix typo in variable name
• Update README with new instructions
• Adjust configuration values
• Simple one-line bug fixes
• Import statement cleanup

Medium (M)

Characteristics:

• Feature additions or enhancements
• Refactoring that touches multiple files but maintains existing behavior
• Breaking changes with backward compatibility
• Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

• Add new feature or component
• Refactor common utility functions
• Update dependencies with minor breaking changes
• Add new component with tests
• Performance optimizations
• More complex bug fixes

Large (L)

Characteristics:

• Major feature implementations
• Breaking changes or API redesigns
• Complex refactoring across multiple modules
• New architectural patterns or significant design changes
• Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

• Complete new feature with frontend/backend changes
• Protocol upgrades or breaking changes
• Major architectural refactoring
• Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

• Test coverage impact: More comprehensive test changes lean toward larger classification
• Risk level: Changes to critical systems bump up a size category
• Team familiarity: Novel patterns or technologies increase complexity

Notes:

• the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
• the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
• do not include any additional text, only the size classification
• your assessment comment must not include tips or additional sections
• do NOT tag me or anyone else on your comment

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

SIZE=M