Open
Conversation
My IDE VSCode was completely reformatting the file without these
fbartho
commented
Jan 12, 2022
| @@ -0,0 +1 @@ | |||
| 14 | |||
Author
There was a problem hiding this comment.
npm versions higher than 6 (which is what comes with node 14) change the version of package-lock.json from 1 to 2.
Version 2 is backwards compatible with package-lock.json version 1, but I didn't want to make that change in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates prettyjson from
colorstochalk- Related: #57 #54This breaks support for the following "colors":
These were present in colors.js and are not present in chalk
One of these "colors" (rainbow) is referenced in a unit test. Options:
A. Delete the unit test
B. Implement this color (and other alternative colors?) on top of chalk.js
Additionally, in chalk 5.x, they have gone ESM-only, so I pinned us to chalk @ 4.x -- chalk's 5.0 release links to Pure ESM
Features
"#FFFFFF"options.unknownColorHandlerby default warns users if a color isn't supported. This warning can be disabled via"ignore", or the user can provide a custom function to render a given input into the expected "color"options.trueColor,options.falseColoroptions.nullUndefinedColorRemaining Tasks
chalk < 5constraint, or decide how to proceed