Open
Conversation
Collaborator
|
Having someone better at Scala review this. Should get it merged this week or early next. |
Collaborator
There was a problem hiding this comment.
I think basic Producer from ch2 is not doing confirm selects. If your intention was to implement this https://github.com/rabbitinaction/sourcecode/blob/master/python/chapter-2/hello_world_producer_pubconfirm.py then you might want to rename the class/file
Author
|
To be honest, I'd just worked through the book's example, I hadn't looked specifically at the Python examples. Have now added classes for the variations in the example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other half of the split containing the chapter two examples in Scala.