Improve consistency with naming #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the QS prefix was automatically inserted some places but not others. This way it is user-controlled by consistent.
On newer macos (26) this was causing: ld: unsupported mach-o filetype (only MH_OBJECT and MH_DYLIB can be linked) in '/tmp/QS/build/Debug/QSTextTools.qsplugin/Contents/MacOS/QSTextTools' Fixes #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QSprefix, keep this naming consistent throughoutPreviously the template would prompt the user for a name, e.g.
MyPlugin, thenprefix this with
QSfor the most part (QSMyPlugin) throughout the generatedcodebase.
This wasn't very explicit, there were a few inconsistencies, and it could easily
lead to someone ending up with
QSQSMyPluginif they weren't aware of this behavior.Better to just suggest that users name the project
QSMyPluginfrom the get-go.Also sneaks in a commit that fixes #3