Standardize default configs and add debug configs#281
Open
leohenon wants to merge 1 commit intoqdrant:masterfrom
Open
Standardize default configs and add debug configs#281leohenon wants to merge 1 commit intoqdrant:masterfrom
leohenon wants to merge 1 commit intoqdrant:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the “default” HNSW construction parameters across the single-node engine configs and adds new “*-debug” configs to make debugger-driven runs easier by forcing single-threaded upload/search.
Changes:
- Updated each
*-defaultconfiguration to use the standardized HNSW build settings (m=16,ef_construction=128in engine-appropriate parameter names). - Added new
*-debugconfigs per engine withparallel=1for bothupload_paramsandsearch_params. - Left specialty configs (on-disk, RPS, quantization variants) unchanged, per the issue/description.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| experiments/configurations/weaviate-single-node.json | Standardized default index build params; added weaviate-debug with single-threaded upload/search. |
| experiments/configurations/redis-single-node.json | Standardized default HNSW index params; added redis-debug with single-threaded upload and reduced search parallelism. |
| experiments/configurations/qdrant-single-node.json | Standardized default hnsw_config; added qdrant-debug with single-threaded upload/search. |
| experiments/configurations/qdrant-native-single-node.json | Standardized default hnsw_config; added qdrant-native-debug with single-threaded upload/search. |
| experiments/configurations/pgvector-single-node.json | Added pgvector-debug with single-threaded upload/search while keeping standardized HNSW build params. |
| experiments/configurations/opensearch-single-node.json | Standardized default ef_construction; added opensearch-debug with single-threaded upload/search. |
| experiments/configurations/milvus-single-node.json | Standardized default efConstruction; added milvus-debug with single-threaded upload/search. |
| experiments/configurations/elasticsearch-single-node.json | Standardized default ef_construction; added elasticsearch-debug with single-threaded upload/search. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137