Skip to content

gh-127750: Fix annotations in singledispatchmethod signature tests #143571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Jan 11, 2026
Merged

gh-127750: Fix annotations in singledispatchmethod signature tests #143571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a5245
Fix `TestSingleDispatch.test_method_signatures` to put annotations on…
johnslavik Jan 8, 2026
85201c3
Keep tests analogous to `test_signatures`
johnslavik Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions Lib/test/test_functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3448,16 +3448,11 @@ def _(item: int, arg: bytes) -> str:

def test_method_signatures(self):
class A:
def m(self, item, arg: int) -> str:
return str(item)
@classmethod
def cm(cls, item, arg: int) -> str:
return str(item)
@functools.singledispatchmethod
def func(self, item, arg: int) -> str:
return str(item)
@func.register
def _(self, item, arg: bytes) -> str:
def _(self, item: int, arg: bytes) -> str:
return str(item)

@functools.singledispatchmethod
Expand All @@ -3466,7 +3461,7 @@ def cls_func(cls, item, arg: int) -> str:
return str(arg)
@func.register
@classmethod
def _(cls, item, arg: bytes) -> str:
def _(cls, item: int, arg: bytes) -> str:
return str(item)

@functools.singledispatchmethod
Expand All @@ -3475,7 +3470,7 @@ def static_func(item, arg: int) -> str:
return str(arg)
@func.register
@staticmethod
def _(item, arg: bytes) -> str:
def _(item: int, arg: bytes) -> str:
return str(item)

self.assertEqual(str(Signature.from_callable(A.func)),
Expand Down
Loading