gh-141536: Fix a crash when running test_capi *after* test_code in the same process #141537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yhg1s
added
skip news
needs backport to 3.13
Member
vstinner
reviewed
Nov 14, 2025
meta-codesync bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Nov 20, 2025
Summary: We need this PR to resolve a segfault - python/cpython#141537 Patching it in now since it may be some time before it lands in upstream + get backported to 3.14 This diff adds a patch to the `third-party/python/3.14` Meta-internal fork. Fix a crash when running test_capi *after* test_code in the same process Reviewed By: itamaro Differential Revision: D87464010 fbshipit-source-id: 79e515ab5733a365ef52c821b06c59f59ded0a7a
itamaro
approved these changes
Jan 4, 2026
Contributor
itamaro
left a comment
itamaro
left a comment
There was a problem hiding this comment.
TIL about late_deletion in test.support!
|
Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 7, 2026
… in the same process (pythonGH-141537) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
|
Sorry, @Yhg1s, I could not cleanly backport this to |
|
GH-143522 is a backport of this pull request to the 3.14 branch. |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Jan 9, 2026
…st_code in the same process (pythonGH-141537) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
|
GH-143625 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.