Open
Conversation
isra17
force-pushed
the
isra/optional-default
branch
from
7f10a7a to
61e8105
Compare
isra17
commented
Apr 27, 2023
| field.load_default = None | ||
| field.allow_none = True | ||
| metadata[_DESERT_SENTINEL]["allow_none"] = True | ||
| if default is marshmallow.missing: |
Collaborator
Author
There was a problem hiding this comment.
I would argue that this behavior is quite counter intuitive, but if we want to keep backward compatibility this is needed.
Collaborator
Author
There was a problem hiding this comment.
If you want an optional value, then do the same as all python code and do x: Optional[int] = None
isra17
force-pushed
the
isra/optional-default
branch
from
61e8105 to
3e9b593
Compare
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 472 476 +4
Branches 90 93 +3
=========================================
+ Hits 472 476 +4
|
Collaborator
|
FYI I don't personally have time to work on this repo these days. Other collaborators should be able to review if they're interested, so you might ping someone to see if there's interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was investigating why
Optionaldefault was broken (ie.x: Optional[int] = 1would default toNone) and ended up refactoring a good bunch of the code, finding out that defaults seemed to be overall quite broken.