Support TypedDict field as Dict[str, Any]#237
Support TypedDict field as Dict[str, Any]#237isra17 wants to merge 1 commit intopython-desert:mainfrom
Conversation
ee3a850 to
267e659
Compare
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 472 499 +27
Branches 90 98 +8
=========================================
+ Hits 472 499 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f6f7a7a to
62f510a
Compare
|
Moved to |
|
Look like 'inspect_typing' has a bug 😞 |
75750d5 to
7965492
Compare
|
It will require #238 to fix the coverage issue. |
94308c3 to
82d0984
Compare
altendky
left a comment
There was a problem hiding this comment.
I'd think it would be nice to support the hints provided by a TypedDict, but this seems a relevant step in that direction and useful on its own. Thanks.
There are a few tweaks I think I'd like. If they explode in your face and make a mess, let me know and we can move forward as is knowing that I may make an attempt at the changes myself after this.
de8324f to
5ce23ac
Compare
|
I addressed your comments! Thanks for the review |
5ce23ac to
158f528
Compare
158f528 to
59519a1
Compare
Title says it all. Nothing to fancy, just a simple mapping of
TypedDict->Dict[str, Any]