[WIP] Improve guarding of Py_DECREF, Py_XDECREF triggered from C++ dtors#5864
Draft
rwgk wants to merge 1 commit intopybind:masterfrom
Draft
[WIP] Improve guarding of Py_DECREF, Py_XDECREF triggered from C++ dtors#5864rwgk wants to merge 1 commit intopybind:masterfrom
Py_DECREF, Py_XDECREF triggered from C++ dtors#5864rwgk wants to merge 1 commit intopybind:masterfrom
Conversation
Based on manual review of: $ cd include/pybind11/ $ git grep -e Py_DECREF -e Py_XDECREF | cut -d: -f1 | uniq conduit/pybind11_conduit_v1.h detail/class.h detail/cpp_conduit.h detail/type_caster_base.h gil_safe_call_once.h numpy.h pybind11.h pytypes.h stl.h stl/filesystem.h trampoline_self_life_support.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently this PR is only pin-pointing code we need to review, based on a quick manual review (
master@ commit aa4259b) of:I think we should look into the suggestions here:
Related: We should also look into our existing uses of
_Py_IsFinalizing(). I think we should (or even need to later) have anis_finalizing()helper:Suggested changelog entry: