Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Collaborator
|
It'd be great to get this resolved before a release: #5796 I won't have time though, just mentioning here in hopes someone familiar with MSVC debugging can jump in. |
Collaborator
Author
|
I'd like to see that fixed, but unless someone is actively working on it, I think we should go ahead and release before I go on vacation tomorrow. There are other fixes I'd like to ship; #5776 sounds quite bad and we probably should have shipped the fix sooner. Maybe we can do a followup 3.0.2 when I'm back a week later. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare for 3.0.1. We might be able to get #5797 in too.
Some minor touchups to the changelog tool to handle empty descriptions better based on what people are leaving in them.
📚 Documentation preview 📚: https://pybind11--5810.org.readthedocs.build/