Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/2.12
branch
from
cf25557 to
ee3a767
Compare
rwgk
reviewed
Mar 26, 2024
Collaborator
|
I have a bunch of obvious/simple bug fixes under #4888 that could be split out from that PR, e.g.
I think I could work on that today or tomorrow. Interested? |
Collaborator
Author
|
You can if you'd like, I can review. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Collaborator
Author
|
Okay, let's release tomorrow. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
approved these changes
Mar 27, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing 2.12. Blocking on #5050 (included in changelog). Would also like #4955. Needs release date.