Conversation
SamuelRiedel
requested review from
mbertuletti,
sermazz and
yichao-zh
as code owners
mbertuletti
reviewed
Sep 23, 2024
Collaborator
mbertuletti
left a comment
mbertuletti
left a comment
There was a problem hiding this comment.
Thank you for the PR. I added some comments and requests.
| $fatal(1, "[mempool] The MemPool cluster is currently limited to 1024 cores."); | ||
|
|
||
| if (NumTiles < NumGroups) | ||
| if (NumTilesPerCluster < NumGroupsPerCluster) |
Collaborator
There was a problem hiding this comment.
A condition should be also added on the number of SubGroups. NumTilesPerGroup > NumSubGroups.
| for (genvar g = 0; g < NumGroups; g++) begin: gen_wfi_groups | ||
| for (genvar sg = 0; sg < NumSubGroupsPerGroup; sg++) begin: gen_wfi_sub_groups | ||
| for (genvar t = 0; t < NumTilesPerSubGroup; t++) begin: gen_wfi_tiles | ||
| for (genvar cl = 0; cl < NumClusters; cl++) begin: gen_wfi_clusters |
Collaborator
There was a problem hiding this comment.
Could we represent the wfi as a multi-dimensional packed array at least on the cluster dimension? This would make the code more readable. This comment is also valid for follwoing signals indexed over the cluster dimension.
Collaborator
There was a problem hiding this comment.
It could be useful to add a barrier function for the synchronization of a single cluster. Are clusters bounded to work all in parallel on the same task at the moment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends MemPool to support multiple clusters. It mainly addresses the hardware side and the basic corresponding software changes. Updating the kernels to multi-cluster kernels will be done in a second step.
Depends on #113 and #114
Changelog
Added
Checklist