Draft
Conversation
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
a9e47cd to
24e7261
Compare
6 tasks
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
24e7261 to
4e2833b
Compare
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
a09de84 to
4525d21
Compare
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
735892a to
8ee38a2
Compare
Signed-off-by: Julius Hinze <julius.hinze@grafana.com>
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
8ee38a2 to
b107693
Compare
…tion Signed-off-by: Julius Hinze <julius.hinze@grafana.com>
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
b107693 to
5d72c76
Compare
aknuds1
reviewed
Jul 4, 2025
Contributor
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
I think it looks pretty good now, except for the IsValidLegacyMetricName doc comment referring to NameValidationScheme.
Contributor
Author
Fixed! |
Member
|
obsoleted by #808 |
Member
|
correction, #808 only removes global validation from the decoder, nowhere else. So this PR is still useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the global
NameValidationSchemeand changes signatures ofLabelName.IsValidandIsValidMetricNameto accept an explicitValidationScheme.